remove NaN in categories checking #20372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jreback merged 1 commit into pandas-dev:master from almaleksia:categories_nan

Mar 16, 2018

Contributor

almaleksia commented Mar 15, 2018

closes Remove more NaN in categories checking #20362
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry


          remove NaN in categories checking

56285b9

jreback added Categorical Clean labels

jreback added this to the 0.23.0 milestone

Contributor

jreback commented Mar 15, 2018

lgtm. ping on green. obviously we didn't have enough tests for this :<

jreback merged commit 4eb9769 into pandas-dev:master

Contributor

jreback commented Mar 16, 2018

thanks @almaleksia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Categorical Clean