Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Plans for 2.7 #20540

Merged
merged 3 commits into from
Apr 14, 2018
Merged

DOC: Plans for 2.7 #20540

merged 3 commits into from
Apr 14, 2018

Conversation

TomAugspurger
Copy link
Contributor

Closes #18894

Just some sample text, essentially following NumPy.

Of course, it'd be nice if 1.0 happened to be the LTS, but we'll see.

@TomAugspurger TomAugspurger added this to the 0.23.0 milestone Mar 29, 2018
@jorisvandenbossche
Copy link
Member

Do we need to send a notice about this to the pydata/pandas-dev mailing list to give people the chance to give feedback?

@codecov
Copy link

codecov bot commented Mar 29, 2018

Codecov Report

Merging #20540 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20540      +/-   ##
==========================================
+ Coverage   91.81%   91.84%   +0.02%     
==========================================
  Files         152      152              
  Lines       49259    49259              
==========================================
+ Hits        45229    45241      +12     
+ Misses       4030     4018      -12
Flag Coverage Δ
#multiple 90.23% <ø> (+0.02%) ⬆️
#single 41.89% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 66.81% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14889f1...cca5024. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Mar 29, 2018

lgtm

this i already promise enough (maybe even too much)

merge away

Starting **January 1, 2019**, all major release will be Python 3 only.

Starting **January 1, 2020**, the pandas maintainers will stop supporting Python 2. The released packages will still be
available on PyPI and through conda, but will not recieve any more bugfixes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo: recieve --> receive

@TomAugspurger
Copy link
Contributor Author

Do we need to send a notice about this to the pydata/pandas-dev mailing list to give people the chance to give feedback?

Sure, are we comfortable with the proposal and timeline? Personally, I'm not sure how much backporting we can commit to doing over 2019. Is there any benefit to being ahead of NumPy here, by a bit, since they're a dependency?

@jreback
Copy link
Contributor

jreback commented Mar 30, 2018

actually I don't think we should commit to a LTS release at all. The final release of 2.7 is Dec 31, 2018.
We could always add that support if someone wants to commit to it (people and funding).

@TomAugspurger
Copy link
Contributor Author

Updated the text about 2.7 support after December 31, 2018 to reflect the default of "we're done with 2.7. If someone wants to continue supporting it, let us know."

@jreback
Copy link
Contributor

jreback commented Mar 30, 2018

lgtm. @jorisvandenbossche

@jreback
Copy link
Contributor

jreback commented Mar 30, 2018

we also need to remember to keep this warning in here for each release

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Mar 30, 2018 via email

Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that sounds reasonable time line

@jreback jreback merged commit d104ecd into pandas-dev:master Apr 14, 2018
@jreback
Copy link
Contributor

jreback commented Apr 14, 2018

thanks @TomAugspurger

@topper-123
Copy link
Contributor

The link in the whatsnew warning doesn't work: http://pandas-docs.github.io/pandas-docs-travis/whatsnew.html

@TomAugspurger TomAugspurger deleted the py27-drop branch April 14, 2018 18:10
@hugovk
Copy link
Contributor

hugovk commented May 6, 2018

I've created a PR to http://www.python3statement.org to add pandas to the timeline:

python3statement/python3statement.github.io#122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants