DEPR: Deprecate DatetimeIndex.offset in favor of DatetimeIndex.freq #20730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschendel
commented
Apr 18, 2018
| @@ -405,6 +405,18 @@ def test_equals(self): | |||
| assert not idx.equals(list(idx3)) | |||
| assert not idx.equals(pd.Series(idx3)) | |||
|
|
|||
| def test_offset_deprecated(self): | |||
There was a problem hiding this comment.
Not sure if this is the ideal location for this test
jorisvandenbossche
approved these changes
Apr 18, 2018
jreback
requested changes
Apr 19, 2018
| @@ -877,6 +877,7 @@ Deprecations | |||
| - The ``convert_datetime64`` parameter in :func:`DataFrame.to_records` has been deprecated and will be removed in a future version. The NumPy bug motivating this parameter has been resolved. The default value for this parameter has also changed from ``True`` to ``None`` (:issue:`18160`). | |||
| - :func:`Series.rolling().apply() <pandas.core.window.Rolling.apply>`, :func:`DataFrame.rolling().apply() <pandas.core.window.Rolling.apply>`, | |||
| :func:`Series.expanding().apply() <pandas.core.window.Expanding.apply>`, and :func:`DataFrame.expanding().apply() <pandas.core.window.Expanding.apply>` have deprecated passing an ``np.array`` by default. One will need to pass the new ``raw`` parameter to be explicit about what is passed (:issue:`20584`) | |||
| - ``DatetimeIndex.offset`` is deprecated. Use ``DatetimeIndex.freq`` instead (:issue:`20716`) | |||
There was a problem hiding this comment.
do we have a ref in api for this?
There was a problem hiding this comment.
it is not mentioned in api.rst, so this is fine
There was a problem hiding this comment.
ah, no, I thought you asked about offset, which we don't need to add since we are deprecating it. freq is already correctly listed in api.rst
1 task
none seen in travis/appveyor |
|
@jschendel Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff