Check boundary undefined with non-default close parameter for DatetimeIndex #23198

[Adirio]

• closes Check boundary undefined with non-default close parameter for date_range #23198
• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[pep8speaks]

Hello @Adirio! Thanks for submitting the PR.

• There are no PEP8 issues in the file pandas/core/arrays/datetimes.py !

[codecov]

Codecov Report

Merging #23199 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #23199      +/-   ##
==========================================
+ Coverage   92.19%   92.19%   +<.01%     
==========================================
  Files         169      169              
  Lines       50956    50956              
==========================================
+ Hits        46977    46978       +1     
+ Misses       3979     3978       -1

Flag	Coverage Δ
#multiple	90.61% <100%> (ø)	⬆️
#single	42.27% <100%> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/core/arrays/datetimes.py	97.61% <100%> (+0.23%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d29e7...077d6a9. Read the comment docs.

[Adirio]

No idea what happened with the failed test.

[jbrockmendel]

The failed test is unrelated; don't worry about it.

This does need its own test though.

[Adirio]

I have no previous experience with pytest, I guess I need to add a new method to the TestDatetimeArray class here that checks that a ValueError is raised if closed != None while one of the boundaries is not given, but no idea how to check that.

[mroeschke]

You can use the pytest.raises context manager and see if the examples in the linked issue will raise a ValueError:

with pytest.raises(ValueError):
    pd.date_range(...)

[jreback]

this would need to assert all of the test cases in the OP

[jreback]

can you merge master and update.

[jreback]

closing as stale. ping if you'd like to continue.

[Adirio]

@jreback I can merge master if you wish but I can not provide the requested tests right now.