Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Tick division, fix Timedelta.__cmp__ tick #24710

Merged
merged 6 commits into from Jan 13, 2019

Conversation

Projects
None yet
2 participants
@jbrockmendel
Copy link
Member

commented Jan 10, 2019

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
@@ -78,6 +81,27 @@ def test_unary_ops(self):


class TestTimedeltaComparison(object):
@pytest.mark.parametrize('tick_cls', [Nano, Micro, Milli, Second,

This comment has been minimized.

Copy link
@jreback

jreback Jan 10, 2019

Contributor

dont' we have this in a fixture? tick_classes?

This comment has been minimized.

Copy link
@jbrockmendel

jbrockmendel Jan 10, 2019

Author Member

just pushed with this change

Show resolved Hide resolved pandas/_libs/tslibs/offsets.pyx

jbrockmendel added some commits Jan 10, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 10, 2019

Codecov Report

Merging #24710 into master will decrease coverage by 49.32%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24710       +/-   ##
===========================================
- Coverage   92.38%   43.06%   -49.33%     
===========================================
  Files         166      166               
  Lines       52311    52311               
===========================================
- Hits        48328    22526    -25802     
- Misses       3983    29785    +25802
Flag Coverage Δ
#multiple ?
#single 43.06% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/tseries/offsets.py 46.06% <100%> (-50.64%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/core/categorical.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.35%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-95.46%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.17%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.15%) ⬇️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bad02e8...b4976d8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jan 10, 2019

Codecov Report

Merging #24710 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24710   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         166      166           
  Lines       52358    52358           
=======================================
  Hits        48374    48374           
  Misses       3984     3984
Flag Coverage Δ
#multiple 90.81% <100%> (ø) ⬆️
#single 43.07% <100%> (-0.03%) ⬇️
Impacted Files Coverage Δ
pandas/tseries/offsets.py 96.69% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc4db2...0a9bb74. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Jan 11, 2019

@jreback

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

does this need a whatsnew note? IOW from a user facing perspective now you can compare offsets & TDs?

@jbrockmendel

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2019

I guess. It's a weird corner case that users shouldn't really get to, but its there.

Would this go in the 0.24.0 file or wait for the next one to exist?

@jreback

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

no you can put it there (0.24)

@jbrockmendel

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2019

Done

@jreback jreback merged commit 097c71f into pandas-dev:master Jan 13, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20190111.28 succeeded
Details
@jreback

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the jbrockmendel:tick1 branch Jan 13, 2019

@jbrockmendel

This comment has been minimized.

Copy link
Member Author

commented Jan 13, 2019

Great. What's the policy for doing stuff during the RC? i.e. there are some more Tick fixups I can do, or test cleanup/parameterization, or ... (or just be patient until after the release)

@jreback

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2019

test things / cleanup are ok

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.