Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #25323 on branch 0.24.x (Skipped broken Py2 / Windows test) #25325

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #25323: Skipped broken Py2 / Windows test

@lumberbot-app lumberbot-app bot added this to the 0.24.2 milestone Feb 14, 2019
@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #25325 into 0.24.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.24.x   #25325   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         166      166           
  Lines       52405    52405           
=======================================
  Hits        48413    48413           
  Misses       3992     3992
Flag Coverage Δ
#multiple 90.8% <ø> (ø) ⬆️
#single 42.87% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e06ec77...bad866d. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #25325 into 0.24.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.24.x   #25325   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         166      166           
  Lines       52405    52405           
=======================================
  Hits        48413    48413           
  Misses       3992     3992
Flag Coverage Δ
#multiple 90.8% <ø> (ø) ⬆️
#single 42.87% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e06ec77...bad866d. Read the comment docs.

@WillAyd
Copy link
Member

WillAyd commented Feb 14, 2019

@jreback not entirely familiar with the process here - do I merge this as well?

@gfyoung gfyoung added 2/3 Compat Windows Windows OS Build Library building on various platforms labels Feb 15, 2019
@gfyoung
Copy link
Member

gfyoung commented Feb 15, 2019

@WillAyd : These are relatively straightforward to merge because we've already vetted and tested on the master branch, so once they're green, you should be able to merge.

@gfyoung gfyoung merged commit fcfd1d4 into pandas-dev:0.24.x Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms Windows Windows OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants