Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #251 #254

Closed
wants to merge 2 commits into from

Conversation

@aman-thakral
Copy link
Contributor

commented Oct 18, 2011

No description provided.

@aman-thakral

This comment has been minimized.

Copy link
Contributor Author

commented on 8264a12 Oct 18, 2011

fixed #251

@@ -2860,12 +2860,14 @@ class DataFrame(NDFrame):
x = range(len(self))

for i, col in enumerate(_try_sort(self.columns)):
empty = np.all(np.isnan(self[col].values))

This comment has been minimized.

Copy link
@wesm

wesm Oct 18, 2011

Member

A better way to do this would be

empty = self.count() == 0
@aman-thakral

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2011

Whoops, forgot to configure my username on a new git install.

@wesm

This comment has been minimized.

Copy link
Member

commented Oct 19, 2011

BTW in the future you'll want to do these changes in a branch instead of in your master branch. I'm going to merge these in but using a rebase which will confuse git if you try to pull in the upstream changes. so I would recommend resetting to before you made these commits, then pulling upstream

@wesm

This comment has been minimized.

Copy link
Member

commented Oct 19, 2011

merged into my master branch, thanks!

@wesm wesm closed this Oct 19, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.