Backport PR #25262 on branch 0.24.x (REF/TST: resample/test_base.py)

[meeseeksmachine]

Backport PR #25262: REF/TST: resample/test_base.py

[codecov]

Codecov Report

Merging #25718 into 0.24.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           0.24.x   #25718   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         166      166           
  Lines       52430    52430           
=======================================
  Hits        48443    48443           
  Misses       3987     3987

Flag	Coverage Δ
#multiple	90.83% <ø> (ø)	⬆️
#single	42.9% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68278a8...9ff83de. Read the comment docs.

[codecov]

Codecov Report

Merging #25718 into 0.24.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           0.24.x   #25718   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         166      166           
  Lines       52430    52430           
=======================================
  Hits        48443    48443           
  Misses       3987     3987

Flag	Coverage Δ
#multiple	90.83% <ø> (ø)	⬆️
#single	42.9% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68278a8...9ff83de. Read the comment docs.

[jorisvandenbossche]

@TomAugspurger why does this need to be backported? For the collection problems?

[TomAugspurger]

Yeah. But if we decide to keep 0.24.x pinned at the older pytest, then this is unnecessary.

…

On Wed, Mar 13, 2019 at 4:56 PM Joris Van den Bossche < ***@***.***> wrote: @TomAugspurger <https://github.com/TomAugspurger> why does this need to be backported? For the collection problems? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25718 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIm0-DcCQDYIpLly65es496DsW02Hks5vWXQWgaJpZM4bwLLl> .

[simonjayhawkins]

@TomAugspurger : if this does solve the collection problem, we can close #25197.

[jreback]

is this mergable or should close?

[jreback]

let's see if this works