Skip to content

PERF: Fix performance regression with Series statistical ops (#25952) #25953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 28, 2019
Merged

PERF: Fix performance regression with Series statistical ops (#25952) #25953

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b147e87
PERF: Fix performance regression with Series statistical ops (#25952)
ArtificialQualia Apr 2, 2019
98abd41
clarify whatsnew
ArtificialQualia Apr 2, 2019
10bc092
removed whatsnew
ArtificialQualia Apr 2, 2019
ac2f9f2
removing unnecessary code
ArtificialQualia Apr 5, 2019
1957a22
fix spacing
ArtificialQualia Apr 5, 2019
ce89e16
force rebuild
ArtificialQualia Apr 5, 2019
7020852
force rebuild
ArtificialQualia Apr 5, 2019
d462002
fore rebuild
ArtificialQualia Apr 5, 2019
0f42f2e
force rebuild
ArtificialQualia Apr 5, 2019
854e784
Merge branch 'master' of https://github.com/pandas-dev/pandas into fi…
ArtificialQualia Apr 28, 2019
92858c1
added comment
ArtificialQualia Apr 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions pandas/core/groupby/grouper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,21 +522,17 @@ def _get_grouper(obj, key=None, axis=0, level=None, sort=True,
any_arraylike = any(isinstance(g, (list, tuple, Series, Index, np.ndarray))
for g in keys)

try:
# is this an index replacement?
if (not any_callable and not any_arraylike and not any_groupers and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some comments here on what is being checked

match_axis_length and level is None):
if isinstance(obj, DataFrame):
all_in_columns_index = all(g in obj.columns or g in obj.index.names
for g in keys)
all_in_columns_index = all(g in obj.columns or g in
obj.index.names for g in keys)
elif isinstance(obj, Series):
all_in_columns_index = all(g in obj.index.names for g in keys)
else:
all_in_columns_index = False
except Exception:
all_in_columns_index = False

if (not any_callable and not all_in_columns_index and
not any_arraylike and not any_groupers and
match_axis_length and level is None):
keys = [com.asarray_tuplesafe(keys)]
if not all_in_columns_index:
keys = [com.asarray_tuplesafe(keys)]

if isinstance(level, (tuple, list)):
if key is None:
Expand Down