Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Unused imports in tslibs #26168

Merged
merged 3 commits into from Apr 21, 2019

Conversation

@mroeschke
Copy link
Member

commented Apr 20, 2019

Removed unused imports in tslibs found via PyCharm.

Matt Roeschke

@mroeschke mroeschke added the Clean label Apr 20, 2019

@@ -381,5 +379,5 @@ cdef class _Timestamp(datetime):

def timestamp(self):
"""Return POSIX timestamp as float."""
# py27 compat, see GH#17329
# Note: tz-aware Timestamps will return a UTC-like timestamp

This comment has been minimized.

Copy link
@jbrockmendel

jbrockmendel Apr 20, 2019

Member

I think keeping the issue reference would be helpful. It is for naive timestamp that we don’t match the stdlib.

Matt Roeschke added some commits Apr 21, 2019

Matt Roeschke

@mroeschke mroeschke added this to the 0.25.0 milestone Apr 21, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 21, 2019

Codecov Report

Merging #26168 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26168      +/-   ##
==========================================
- Coverage   91.98%   91.97%   -0.01%     
==========================================
  Files         175      175              
  Lines       52377    52377              
==========================================
- Hits        48180    48176       -4     
- Misses       4197     4201       +4
Flag Coverage Δ
#multiple 90.53% <100%> (ø) ⬆️
#single 40.71% <66.66%> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/tseries/frequencies.py 97.69% <100%> (ø) ⬆️
pandas/core/arrays/datetimes.py 97.79% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc86509...2c5688c. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Apr 21, 2019

Codecov Report

Merging #26168 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26168      +/-   ##
==========================================
- Coverage   91.98%   91.97%   -0.01%     
==========================================
  Files         175      175              
  Lines       52377    52377              
==========================================
- Hits        48180    48176       -4     
- Misses       4197     4201       +4
Flag Coverage Δ
#multiple 90.53% <100%> (ø) ⬆️
#single 40.71% <66.66%> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/tseries/frequencies.py 97.69% <100%> (ø) ⬆️
pandas/core/arrays/datetimes.py 97.79% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc86509...2c5688c. Read the comment docs.

@jreback jreback merged commit 966d09e into pandas-dev:master Apr 21, 2019

11 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20190421.5 succeeded
Details
pandas-dev.pandas (Checks_and_doc) Checks_and_doc succeeded
Details
pandas-dev.pandas (Linux py35_compat) Linux py35_compat succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow) Linux py36_locale_slow succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow_old_np) Linux py36_locale_slow_old_np succeeded
Details
pandas-dev.pandas (Linux py37_locale) Linux py37_locale succeeded
Details
pandas-dev.pandas (Linux py37_np_dev) Linux py37_np_dev succeeded
Details
pandas-dev.pandas (Windows py36_np15) Windows py36_np15 succeeded
Details
pandas-dev.pandas (Windows py37_np141) Windows py37_np141 succeeded
Details
pandas-dev.pandas (macOS py35_macos) macOS py35_macos succeeded
Details
@jreback

This comment has been minimized.

Copy link
Contributor

commented Apr 21, 2019

thanks @mroeschke

@mroeschke mroeschke deleted the mroeschke:tslib_cython_imports branch Apr 21, 2019

ryanreh99 added a commit to ryanreh99/pandas that referenced this pull request Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.