Skip to content

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Apr 23, 2019

dump and load don't appear anywhere in the code base except for UltraJSON tests. Since they are part of the exposed API I figure makes just as much sense to remove

@WillAyd WillAyd added IO JSON read_json, to_json, json_normalize Clean labels Apr 23, 2019
@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #26198 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26198      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52372    52372              
==========================================
- Hits        48176    48173       -3     
- Misses       4196     4199       +3
Flag Coverage Δ
#multiple 90.53% <ø> (ø) ⬆️
#single 40.7% <ø> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.71% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74901b...5cd68e0. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #26198 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26198      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52375    52375              
==========================================
- Hits        48180    48175       -5     
- Misses       4195     4200       +5
Flag Coverage Δ
#multiple 90.53% <ø> (ø) ⬆️
#single 40.7% <ø> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.61% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e05d7...eac0a4d. Read the comment docs.

@jbrockmendel
Copy link
Member

Nice. Those C files are hard to work in; I’m glad to see them getting trimmed down.

@jreback jreback added this to the 0.25.0 milestone Apr 24, 2019
@jreback
Copy link
Contributor

jreback commented Apr 24, 2019

fine with this, can you add a whatsnew note just to document; also a lint error.

@jreback
Copy link
Contributor

jreback commented Apr 24, 2019

can you rebase

@jreback jreback merged commit 3de7139 into pandas-dev:master Apr 25, 2019
@jreback
Copy link
Contributor

jreback commented Apr 25, 2019

thanks @WillAyd

@WillAyd WillAyd deleted the json-cleanup branch April 25, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean IO JSON read_json, to_json, json_normalize

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants