Skip to content

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Apr 25, 2019

Continuing cleanup of ujson source there are some preprocessor directives in there which are no longer valid given minimum Python and NumPy versions

@WillAyd WillAyd added Clean IO JSON read_json, to_json, json_normalize labels Apr 25, 2019
@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #26211 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26211      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52375    52375              
==========================================
- Hits        48180    48176       -4     
- Misses       4195     4199       +4
Flag Coverage Δ
#multiple 90.53% <ø> (ø) ⬆️
#single 40.7% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de7139...d7cc968. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #26211 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26211      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52375    52375              
==========================================
- Hits        48180    48176       -4     
- Misses       4195     4199       +4
Flag Coverage Δ
#multiple 90.53% <ø> (ø) ⬆️
#single 40.7% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de7139...d7cc968. Read the comment docs.

@jreback jreback added this to the 0.25.0 milestone Apr 26, 2019
@jreback jreback merged commit b2b09b7 into pandas-dev:master Apr 26, 2019
@jreback
Copy link
Contributor

jreback commented Apr 26, 2019

thanks

@WillAyd WillAyd deleted the ujson-version-checks branch January 16, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean IO JSON read_json, to_json, json_normalize

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants