Skip to content

Conversation

mroeschke
Copy link
Member

While discussion on other support avenues are still ongoing, I think it would still be beneficial to add the a Sponsors Button to the repo that points to https://pandas.pydata.org/donate.html

Note: https://www.flipcause.com/secure/cause_pdetails/MzA3OA== is the direct page to donate but this link doesn't appear as "donate friendly" IMO

Let me know if there's a better link to reference

Reference to the Support Button on Numpy's page: numpy/numpy#13700

@gfyoung gfyoung added the Docs label Jun 6, 2019
@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #26694 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26694      +/-   ##
==========================================
- Coverage   91.88%   91.87%   -0.01%     
==========================================
  Files         174      174              
  Lines       50701    50701              
==========================================
- Hits        46588    46584       -4     
- Misses       4113     4117       +4
Flag Coverage Δ
#multiple 90.41% <ø> (ø) ⬆️
#single 41.9% <ø> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649ad5c...50b6089. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #26694 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26694      +/-   ##
==========================================
- Coverage   91.88%   91.87%   -0.01%     
==========================================
  Files         174      174              
  Lines       50701    50701              
==========================================
- Hits        46588    46584       -4     
- Misses       4113     4117       +4
Flag Coverage Δ
#multiple 90.41% <ø> (ø) ⬆️
#single 41.9% <ø> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649ad5c...c313b3d. Read the comment docs.

@@ -0,0 +1 @@
custom: https://pandas.pydata.org/donate.html No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need a newline?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like other projects have a newline in their yml, will add one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol thanks

@jreback jreback added this to the 0.25.0 milestone Jun 7, 2019
@jreback jreback merged commit 3ff4f38 into pandas-dev:master Jun 7, 2019
@jreback
Copy link
Contributor

jreback commented Jun 7, 2019

where exactly should the sponsor button appear?

@mroeschke
Copy link
Member Author

Looks like we need to enable it in the "Settings" menu of the repository, but I can't immediately find it:

https://help.github.com/en/articles/displaying-a-sponsor-button-in-your-repository

@mroeschke
Copy link
Member Author

I may not have enough permissions to access the repository settings. Can you enable it @jreback?

Screen Shot 2019-06-07 at 10 23 01 AM

@mroeschke mroeschke deleted the github_sponsors_button branch June 7, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants