CLN: de-kludge quantile, make interpolate_with_fill understand datetime64 #27626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Jul 27, 2019
| # Such assignment may incorrectly coerce NaT to None | ||
| # result[blk.mgr_locs] = blk._slice((slice(None), loc)) | ||
| for i, rl in enumerate(blk.mgr_locs): | ||
| result[rl] = blk._try_coerce_result(blk.iget((i, loc))) |
There was a problem hiding this comment.
this change is unrelated to the 2 mentioned in the OP, just an unnecessary call
jbrockmendel
commented
Jul 27, 2019
| mask = _safe_reshape(mask, new_values.shape) | ||
|
|
||
| new_values[mask] = new | ||
| new_values = self._try_coerce_result(new_values) |
There was a problem hiding this comment.
unrelated to 2 topics mentioned in OP, just unnecessary
This was referenced Jul 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 related-but-separate things here
-quantile: de-kludging the base class method and putting the datetimetz-specific stuff in a subclass method. This will allow us to implement the refactor suggested in #14562. If/when DTA supports 2D, we'll be able to get rid of the subclass override kludge altogether.