BUG: fix+test PA+all-NaT TDA #27739
Merged
BUG: fix+test PA+all-NaT TDA #27739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Aug 4, 2019
|
|
||
| # Note: we use Series instead of TimedeltaIndex to avoid having | ||
| # to worry about catching NullFrequencyError. | ||
| return pd.Series(right) |
There was a problem hiding this comment.
rather than this can you make a safe method that deals with null frequency, this is a bit odd
There was a problem hiding this comment.
This basically is the safe method to deal with null frequency. I think there will be room to simplify it after we merge dispatch_to_index_op into dispatch_to_extension_op
(I agree that I'd prefer these methods not need to know about Series)
There was a problem hiding this comment.
ok fair enough, maybe make an issue about this? (or just add to your list) :->
jreback
added
Missing-data
jreback
approved these changes
Aug 4, 2019
|
thanks |
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffIn conjunction with one more branch coming up, we're going to simplify the tar out of Series arithmetic ops.