Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Series.rename raises error on values accepted by Series construc… #27814

Merged
merged 7 commits into from Aug 22, 2019

Conversation

@lgmsantos
Copy link
Contributor

commented Aug 8, 2019

@jbrockmendel

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Needs a test

@pep8speaks

This comment has been minimized.

Copy link

commented Aug 8, 2019

Hello @lgmsantos! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-08-22 11:33:56 UTC
@TomAugspurger
Copy link
Contributor

left a comment

Can you add a release note to doc/source/whatsnew/v0.25.1.rst?

@TomAugspurger TomAugspurger added this to the 0.25.1 milestone Aug 8, 2019

@lgmsantos

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

How can I fix those failed checks? They seem unrelated to the changes.

@TomAugspurger

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

Try merging master and re-pushing?

@TomAugspurger

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Merged master. Ping on green.

@TomAugspurger TomAugspurger merged commit b1c871c into pandas-dev:master Aug 22, 2019

13 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20190822.12 succeeded
Details
pandas-dev.pandas (Checks) Checks succeeded
Details
pandas-dev.pandas (Docs) Docs succeeded
Details
pandas-dev.pandas (Linux py35_compat) Linux py35_compat succeeded
Details
pandas-dev.pandas (Linux py36_32bit) Linux py36_32bit succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow) Linux py36_locale_slow succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow_old_np) Linux py36_locale_slow_old_np succeeded
Details
pandas-dev.pandas (Linux py37_locale) Linux py37_locale succeeded
Details
pandas-dev.pandas (Linux py37_np_dev) Linux py37_np_dev succeeded
Details
pandas-dev.pandas (Windows py36_np15) Windows py36_np15 succeeded
Details
pandas-dev.pandas (Windows py37_np141) Windows py37_np141 succeeded
Details
pandas-dev.pandas (macOS py35_macos) macOS py35_macos succeeded
Details
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 22, 2019
TomAugspurger added a commit that referenced this pull request Aug 22, 2019
galuhsahid added a commit to galuhsahid/pandas that referenced this pull request Aug 25, 2019
BUG: Series.rename raises error on values accepted by Series construc… (
pandas-dev#27814)

* BUG: Series.rename raises error on values accepted by Series constructor.
galuhsahid added a commit to galuhsahid/pandas that referenced this pull request Aug 25, 2019
Merge branch 'master' into parquet-categorical
* master: (40 commits)
  DOC: Fix GL01 and GL02 errors in the docstrings (pandas-dev#27988)
  Remove Encoding of values in char** For Labels (pandas-dev#27618)
  TYPING: more type hints for io.formats.printing (pandas-dev#27765)
  TST: fix compression tests when run without virtualenv/condaenv (pandas-dev#28051)
  DOC: Start 0.25.2 (pandas-dev#28111)
  DOC: Fix docstrings lack of punctuation (pandas-dev#28031)
  DOC: Remove alias for numpy.random.randn from the docs (pandas-dev#28082)
  DOC: update GroupBy.head()/tail() documentation (pandas-dev#27844)
  BUG: timedelta merge asof with tolerance (pandas-dev#27650)
  BUG: Series.rename raises error on values accepted by Series construc… (pandas-dev#27814)
  Preserve index when setting new column on empty dataframe. (pandas-dev#26471)
  BUG: Fixed groupby quantile for listlike q (pandas-dev#27827)
  BUG: iter with readonly values, closes pandas-dev#28055 (pandas-dev#28074)
  TST: non-strict xfail for period test (pandas-dev#28072)
  DOC: Update whatsnew (pandas-dev#28073)
  CI: disable codecov (pandas-dev#28065)
  CI: Set SHA for codecov upload (pandas-dev#28067)
  BUG: Correct the previous bug fixing on xlim for plotting (pandas-dev#28059)
  CI: Add pip dependence explicitly (pandas-dev#28008)
  DOC: Change document code prun in a row (pandas-dev#28029)
  ...
gabriellm1 added a commit to gabriellm1/pandas that referenced this pull request Aug 27, 2019
BUG: Series.rename raises error on values accepted by Series construc… (
pandas-dev#27814)

* BUG: Series.rename raises error on values accepted by Series constructor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.