Skip to content

REF: use dispatch_to_extension_op for bool ops #27959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2019
Merged

REF: use dispatch_to_extension_op for bool ops #27959

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89f61c2
dispatch to extension
jbrockmendel Aug 16, 2019
7480580
use extension dispatch
jbrockmendel Aug 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pandas/core/ops/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,6 +818,11 @@ def wrapper(self, other):
# Defer to DataFrame implementation; fail early
return NotImplemented

elif should_extension_dispatch(self, other):
# e.g. SparseArray
res_values = dispatch_to_extension_op(op, self, other)
return _construct_result(self, res_values, index=self.index, name=res_name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is res_values always an array, or can it be a tuple of results, like from divmod?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this context its always an array


elif isinstance(other, (ABCSeries, ABCIndexClass)):
is_other_int_dtype = is_integer_dtype(other.dtype)
other = fill_int(other) if is_other_int_dtype else fill_bool(other)
Expand Down