Skip to content

TYPING: --check-untyped-defs for Index.__new__ #28141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2019
Merged

TYPING: --check-untyped-defs for Index.__new__ #28141

merged 1 commit into from
Aug 26, 2019

Conversation

simonjayhawkins
Copy link
Member

xref #27568

pandas\core\indexes\base.py:335: error: Incompatible types in assignment (expression has type "TimedeltaIndex", variable has type "DatetimeIndex")
pandas\core\indexes\base.py:338: error: Incompatible types in assignment (expression has type "TimedeltaIndex", variable has type "DatetimeIndex")
pandas\core\indexes\base.py:346: error: Incompatible types in assignment (expression has type "PeriodIndex", variable has type "DatetimeIndex")
pandas\core\indexes\base.py:408: error: Name 'PeriodIndex' already defined on line 74
pandas\core\indexes\base.py:408: error: Module 'pandas.core.indexes.period' has no attribute 'IncompatibleFrequency'
pandas\core\indexes\base.py:419: error: Name 'Float64Index' already defined on line 349
pandas\core\indexes\base.py:443: error: Name 'Float64Index' already defined on line 349
pandas\core\indexes\base.py:447: error: Name 'IntervalIndex' already defined on line 170
pandas\core\indexes\base.py:459: error: Name 'DatetimeIndex' already defined on line 88
pandas\core\indexes\base.py:470: error: Name 'TimedeltaIndex' already defined on line 57

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Aug 25, 2019
WillAyd
WillAyd approved these changes Aug 25, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added this to the 1.0 milestone Aug 25, 2019
@jbrockmendel
Copy link
Member

LGTM

@WillAyd WillAyd merged commit cebc343 into pandas-dev:master Aug 26, 2019
@WillAyd
Copy link
Member

WillAyd commented Aug 26, 2019

Thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the Index.__new__ branch August 27, 2019 09:30
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@simonjayhawkins @proost
TYPING: --check-untyped-defs for Index.__new__ (pandas-dev#28141)
e43996f
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@simonjayhawkins @proost
TYPING: --check-untyped-defs for Index.__new__ (pandas-dev#28141)
a6536ca
@jorisvandenbossche jorisvandenbossche mentioned this pull request Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees

No one assigned

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@simonjayhawkins @jbrockmendel @WillAyd