Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
ENH Assert_frame_equal check_names to True #2964
This is a follow up to #2962, where I added a
I've added in
i.e. these appear to drop column names (
Note: By changing the A1 cells to 'index', I had all but one test (labelled "read xls ignores index name ?") in
so I reverted to the previous xls and xlsx, and added back in
I'm being a bit wary of changing the behaviour of assert_frame_equals if you're not onboard. (Since, it could lead to test passes merging into test fails, if assert_frame_equals is used in a test to frames with distinct column/index names.)
The original PR #2962 does just that (sets it to False), this second one sets it True...
I had to go in and fixed those calls to assert_frame_equals where it wasn't working, either by setting check_names=False, changing the name (of an expected/result) or flagging it with TODO (and setting check_names=False) if I thought it could be a bug.
Then I (or someone) can then follow them up :)