Make resample documentation better #30252
Conversation
|
Hello @anshbansal! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-12-13 04:57:03 UTC |
| @@ -7708,6 +7708,8 @@ def resample( | |||
| ---------- | |||
| rule : DateOffset, Timedelta or str | |||
| The offset string or object representing target conversion. | |||
| The str value refers to frequency string. | |||
There was a problem hiding this comment.
this line is redundant. you can add a link the documentation if you'd like; i think we have this link elsewhere.
|
@anshbansal still interested on finishing this? If so, please remove the line that doesn't add value and create a link to the mentioned page/section. Thanks |
|
@jreback @datapythonista Can you tell me what link is being referred to in the previous comment? |
| @@ -7708,6 +7708,8 @@ def resample( | |||
| ---------- | |||
| rule : DateOffset, Timedelta or str | |||
| The offset string or object representing target conversion. | |||
| The str value refers to frequency string. | |||
| The list of valid values can be found in the timeseries user guide. | |||
There was a problem hiding this comment.
@anshbansal making this a link to the timeseries user guide, besides saying it.
There was a problem hiding this comment.
|
Closing as stale, @anshbansal let us know if you'd like to finish this. |
I removed the checkboxes because they were not relevant. This is a docstring update. I found the answer in https://stackoverflow.com/questions/17001389/pandas-resample-documentation but it should have been present in the docs