Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Replace fstring in tests/groupby/*.py files #30700

Merged
merged 2 commits into from
Jan 4, 2020
Merged

CLN: Replace fstring in tests/groupby/*.py files #30700

merged 2 commits into from
Jan 4, 2020

Conversation

Sangarshanan
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Ref to #29547

@alimcmaster1 alimcmaster1 added Clean Code Style Code style, linting, code_checks labels Jan 4, 2020
@jreback jreback added this to the 1.0 milestone Jan 4, 2020
topper-123
topper-123 approved these changes Jan 4, 2020
View reviewed changes
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I can merge it when it's green.

@jreback jreback merged commit 1c35fba into pandas-dev:master Jan 4, 2020
@jreback
Copy link
Contributor

jreback commented Jan 4, 2020

thanks @Sangarshanan

@Sangarshanan Sangarshanan deleted the fstring-testgroupby branch January 5, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topper-123 topper-123 topper-123 approved these changes

Assignees
No one assigned
Labels
Clean Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sangarshanan @jreback @topper-123 @alimcmaster1