CI: Disallow bare pytest raise #30737
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Jan 6, 2020
| ) | ||
| ) | ||
|
|
||
| for subdir, _, files in os.walk(source_path): |
There was a problem hiding this comment.
i think it would be nice to encapsulate most of the boiler plate in a common file used in the other validate_* scripts. can you do this as a pre-cursor PR
There was a problem hiding this comment.
That is exactly what I was a about to ask, if I should do so.
The only question I have is how the script should be activated?
for example like this:
./scripts/validate_patterns.py --bare-pytest --concat-strings pandas
or
./scripts/validate_patterns.py --test-cases="barepytest,concatstrins" pandas
5 tasks
|
Closing in favor in #30755 |
|
Is it possible to do this via regex? similar to the current code check for context manager: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff