Skip to content

Conversation

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Jan 7, 2020
@mroeschke mroeschke added this to the 1.0 milestone Jan 7, 2020
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mroeschke lgtm ex comments.

@@ -47,6 +47,24 @@ def test_flex_method_equivalence(self, opname, ts):
expected = alt(other, series)
tm.assert_almost_equal(result, expected)

@pytest.mark.parametrize(
"opname", ["add", "sub", "mul", "floordiv", "truediv", "pow"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to use all_arithmetic_operators fixture here


def test_map_float_to_string_precision(self):
# GH 13228
x = pd.Series(1 / 3)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, s or ser.

@jreback
Copy link
Contributor

jreback commented Jan 7, 2020

lgtm. if you'd update to @simonjayhawkins comments, then merge on green.

@mroeschke mroeschke merged commit 5d407cf into pandas-dev:master Jan 7, 2020
@mroeschke mroeschke deleted the more_testing branch January 7, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
3 participants