STY: concat strings that should not be seperated #30942
Conversation
pandas/_libs/window/aggregations.pyx
Outdated
| if minp > win_n: | ||
| raise ValueError(f"min_periods (minp) must be <= " | ||
| f"window (win)") | ||
| raise ValueError(f"min_periods {minp} must be <= window {win_n}") |
There was a problem hiding this comment.
The f did nothing before. should I revert and just delete the f?
or leave it as it is?
There was a problem hiding this comment.
I think leave the message unchanged unless obvious improvement and then should add a brief note in whatsnew that message has been changed.
There was a problem hiding this comment.
I think I'll just delete this f because it didn't do anything anyway.
pandas/_libs/window/aggregations.pyx
Outdated
| if minp > win_n: | ||
| raise ValueError(f"min_periods (minp) must be <= " | ||
| f"window (win)") | ||
| raise ValueError(f"min_periods {minp} must be <= window {win_n}") |
There was a problem hiding this comment.
I think leave the message unchanged unless obvious improvement and then should add a brief note in whatsnew that message has been changed.
Co-Authored-By: Simon Hawkins <simonjayhawkins@gmail.com>
@simonjayhawkins should I close this PR then? |
I think OK to merge this once the changed message #30942 (comment) is reverted |
|
ping @simonjayhawkins |
|
Thanks @MomIsBestFriend |
3 participants
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff