Skip to content

REG: restore format_type attr #31017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 22, 2020
Merged

REG: restore format_type attr #31017

merged 3 commits into from
Jan 22, 2020

Conversation

jbrockmendel
Copy link
Member

@TomAugspurger
Copy link
Contributor

Thanks. Two questions:

  1. Thoughts on the need for a simple test? I worry a bit about a comment being overlooked in a future refactor clearing stuff out / looking at "dead" code.
  2. Do we want this API going forward? Clearly, we don't have a need for it. Is there an alternative we should deprecate in favor of?

@TomAugspurger TomAugspurger added this to the 1.0.0 milestone Jan 14, 2020
@TomAugspurger TomAugspurger added the IO HDF5 read_hdf, HDFStore label Jan 14, 2020
@simonjayhawkins
Copy link
Member

  1. Thoughts on the need for a simple test?

code sample in issue as test in pandas\tests\test_downstream.py

@simonjayhawkins
Copy link
Member

wrong button!

@simonjayhawkins simonjayhawkins added the Regression Functionality that used to work in a prior pandas version label Jan 14, 2020
@jbrockmendel
Copy link
Member Author

@TomAugspurger suggestions for a snippet to test?

@TomAugspurger
Copy link
Contributor

Nothing fancy. Just an asset that hdf.get_storer(key).format_type is the expected value for that format

@WillAyd
Copy link
Member

WillAyd commented Jan 15, 2020

Is the purpose of this field documented anywhere? If not can we add a comment?

@TomAugspurger
Copy link
Contributor

Pushed a test.

@TomAugspurger
Copy link
Contributor

Is the purpose of this field documented anywhere? If not can we add a comment?

IMO we can keep PR to just fixing the regression.

@TomAugspurger
Copy link
Contributor

Thanks @jbrockmendel.

@TomAugspurger TomAugspurger merged commit f4c99ff into pandas-dev:master Jan 22, 2020
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 22, 2020
@jbrockmendel @meeseeksmachine
Backport PR pandas-dev#31017: REG: restore format_type attr
a323b25
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 22, 2020
Merged
@jbrockmendel jbrockmendel deleted the ref-format_type branch January 22, 2020 15:47
TomAugspurger pushed a commit that referenced this pull request Jan 22, 2020
@meeseeksmachine @jbrockmendel @TomAugspurger
Backport PR #31017: REG: restore format_type attr (#31206)
d5068ea 
Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
IO HDF5 read_hdf, HDFStore Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

AttributeError: 'FrameFixed' object has no attribute 'format_type' on 1.0.0rc0
4 participants
@jbrockmendel @TomAugspurger @simonjayhawkins @WillAyd