REG: Restore read_csv function for some file-likes #32577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Regression
gfyoung
force-pushed
the
file-like-obj-restore
branch
from
cd1c3a4 to
df83963
Compare
Restores behavior down to the fact that the Python engine cannot handle NamedTemporaryFile. Closes pandas-dev#31819 Credit to @sasanquaneuf for originating idea.
gfyoung
force-pushed
the
file-like-obj-restore
branch
from
df83963 to
1bcaaba
Compare
|
Alrighty, everything is finally green! If people can take a look at and give feedback on this, that would be great so we can get this merged before tomorrow. |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Mar 11, 2020
jreback
pushed a commit
that referenced
this pull request
Mar 11, 2020
#32609) Co-authored-by: gfyoung <gfyoung17@gmail.com>
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Restores behavior down to the fact that the Python engine cannot handle NamedTemporaryFile. Closes pandas-dev#31819 Credit to @sasanquaneuf for originating idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore
read_csvfunction for some file-likesRestores behavior down to the fact that the Python engine cannot handle NamedTemporaryFile.
Closes #31819
Credit to @sasanquaneuf for originating idea.