Skip to content

Conversation

SaturnFromTitan
Copy link
Contributor

part of #31989

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@SaturnFromTitan
Copy link
Contributor Author

Apart from one helper function rename and a new docstring (marked with a comment), this is purely a reordering.

I suggest to just read the new pandas/conftest.py instead of the "Files changed" tab

@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Mar 17, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Mar 17, 2020
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @SaturnFromTitan lgtm.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. pls merge master and ping on green.

@SaturnFromTitan
Copy link
Contributor Author

@jreback CI isn't green, but the failure isn't related. The same check fails for a lot of other PRs. -> I think this is good to be merged

@simonjayhawkins simonjayhawkins merged commit d308712 into pandas-dev:master Mar 20, 2020
@simonjayhawkins
Copy link
Member

Thanks @SaturnFromTitan

SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants