BUG: is_scalar_indexer #32850
Merged
BUG: is_scalar_indexer #32850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there an actual bug that this fixes? (do you have an example with indexing that now did the wrong thing?) |
Nothing user-facing, just an unnecessary failed-cast: ATM this incorrectly doesnt see the indexer as a scalar-indexer, but does see this (also incorrectly) as an |
jreback
reviewed
Mar 20, 2020
pandas/core/internals/blocks.py
Outdated
| values = values.astype(arr_value.dtype) | ||
| except ValueError: | ||
| pass | ||
| values = values.astype(arr_value.dtype) |
There was a problem hiding this comment.
can add copy=False here I think
jreback
added
Clean
Indexing
…titem-exact_match
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
* BUG: is_scalar_indexer * update docstring * add copy=False
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 23, 2020
* BUG: is_scalar_indexer * update docstring * add copy=False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffATM we go through the wrong path when setting a listlike entry in a single position.
The broader goal: separate out the cases where setitem is inplace vs copying.