STY: Boolean values for bint variables #33009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # is a general, O(max(len(values), len(binner))) method. | ||
| @cython.boundscheck(False) | ||
| @cython.wraparound(False) | ||
| def generate_bins_dt64(ndarray[int64_t] values, const int64_t[:] binner, |
There was a problem hiding this comment.
can values here be `const int64_t[:]``
There was a problem hiding this comment.
No, cython raises errors
[1/1] Cythonizing pandas/_libs/lib.pyx
Error compiling Cython file:
------------------------------------------------------------
...
int64_t l_bin, r_bin, nat_count
bint right_closed = closed == 'right'
nat_count = 0
if hasnans:
mask = values == NPY_NAT
^
------------------------------------------------------------
pandas/_libs/lib.pyx:707:22: Invalid types for '==' (const int64_t[:], int64_t)
warning: pandas/_libs/lib.pyx:709:24: Index should be typed for more efficient access
Error compiling Cython file:
------------------------------------------------------------
...
nat_count = 0
if hasnans:
mask = values == NPY_NAT
nat_count = np.sum(mask)
values = values[~mask]
^
------------------------------------------------------------
pandas/_libs/lib.pyx:709:23: Cannot convert 'int64_t' to memoryviewslice
Traceback (most recent call last):
File "setup.py", line 791, in <module>
setup_package()
File "setup.py", line 761, in setup_package
ext_modules=maybe_cythonize(extensions, compiler_directives=directives),
File "setup.py", line 534, in maybe_cythonize
return cythonize(extensions, *args, **kwargs)
File "/home/bummy/miniconda3/envs/pandas-dev/lib/python3.7/site-packages/Cython/Build/Dependencies.py", line 1102, in cythonize
cythonize_one(*args)
File "/home/bummy/miniconda3/envs/pandas-dev/lib/python3.7/site-packages/Cython/Build/Dependencies.py", line 1225, in cythonize_one
raise CompileError(None, pyx_file)
Cython.Compiler.Errors.CompileError: pandas/_libs/lib.pyx
|
Same comment as #33008 - a lot of the Cython stuff is performance critical so really want to be sure |
|
can you just verify that the same code is generated here as well, otherwise lgtm. |
|
@jreback I checked and the generated C code, is identical. (Only diff is in the comments) |
|
thanks @MomIsBestFriend I suppose if we had a code check to catch this would be great, but might not be so easy to check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff