Clean Up Categorical Test for JSON #33228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
added
IO JSON
WillAyd
commented
Apr 2, 2020
| data = self.categorical.to_json(orient=orient) | ||
| if numpy and orient in ("records", "values"): | ||
| data = df.to_json(orient=orient) | ||
| if numpy and orient != "split": |
There was a problem hiding this comment.
I removed the xfail preceding this because it was no longer applicable, but it unearthed a new issue when numpy=True and any orient except split.
That keyword is deprecated in #28512 and scheduled for removal in 2.0, so figured not worth investing much in
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mroeschke
approved these changes
Apr 3, 2020
|
thanks @WillAyd |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little wonky in its current state, bolting categoricals onto an existing object / fixture
Instead just localized this to the one test that covers it for now