CLN: Added static types _libs/algos #33271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaharNaveh
commented
Apr 3, 2020
| @cython.boundscheck(False) | ||
| @cython.wraparound(False) | ||
| def nancorr(const float64_t[:, :] mat, bint cov=0, minp=None): | ||
| def nancorr(const float64_t[:, :] mat, bint cov=False, minp=None): |
There was a problem hiding this comment.
The generated C code for this was not changed
| float64_t sum_ranks = 0 | ||
| int tiebreak = 0 | ||
| bint keep_na = 0 | ||
| bint keep_na = False |
There was a problem hiding this comment.
The generated C code for this was not changed
| float64_t sum_ranks = 0 | ||
| int tiebreak = 0 | ||
| bint keep_na = 0 | ||
| bint keep_na = False |
There was a problem hiding this comment.
The generated C code for this was not changed
WillAyd
reviewed
Apr 3, 2020
| @cython.boundscheck(False) | ||
| @cython.wraparound(False) | ||
| def nancorr_spearman(const float64_t[:, :] mat, Py_ssize_t minp=1): | ||
| def nancorr_spearman(const float64_t[:, :] mat, Py_ssize_t minp=1) -> ndarray: |
There was a problem hiding this comment.
Does adding these return annotations to the def like this change anything?
There was a problem hiding this comment.
for functions that arent cdef/cpdef its ornamental
|
thanks @MomIsBestFriend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff