Skip to content

CLN: avoid catching AssertionError, AttributeError in NDFrame methods #33615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2020
Merged

CLN: avoid catching AssertionError, AttributeError in NDFrame methods #33615

merged 2 commits into from
Apr 21, 2020

Conversation

jbrockmendel
Copy link
Member

@WillAyd when i run mypy manually it passes, but when run via the pre-commit hook I get

pandas/core/internals/blocks.py:2739: error: unused 'type: ignore' comment
pandas/core/generic.py:4034: error: unused 'type: ignore' comment
pandas/core/generic.py:4093: error: unused 'type: ignore' comment
Found 3 errors in 2 files (checked 2 source files)

Something similar is happening with most branches these days. Have you seen this?

@jreback
Copy link
Contributor

jreback commented Apr 17, 2020

looks ok, needs a rebase

@jreback jreback added the Clean label Apr 17, 2020
@jreback jreback added this to the 1.1 milestone Apr 17, 2020
@jbrockmendel
Copy link
Member Author

updated+green

@WillAyd
Copy link
Member

WillAyd commented Apr 18, 2020

I think @xhochy has some experience with that pre-commit / mypy issue

@jreback jreback merged commit 0c55e91 into pandas-dev:master Apr 21, 2020
@jbrockmendel jbrockmendel deleted the cln-reset branch April 21, 2020 14:56
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
@jbrockmendel @rhshadrach
CLN: avoid catching AssertionError, AttributeError in NDFrame methods (…
f6708b2 
…pandas-dev#33615)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Clean

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@jbrockmendel @jreback @WillAyd