Skip to content

Conversation

mproszewska
Copy link
Contributor

@mproszewska mproszewska changed the title BUG: Ignoring columns from index_col in _is_potential_multi_index BUG: Handling columns from index_col in _is_potential_multi_index May 4, 2020
@jreback jreback added IO Excel read_excel, to_excel MultiIndex labels May 5, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add a csv test that hits this

@jreback jreback requested a review from gfyoung May 10, 2020 15:26
@jreback jreback added this to the 1.1 milestone May 10, 2020
@pep8speaks
Copy link

pep8speaks commented May 10, 2020

Hello @mproszewska! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-01 00:42:28 UTC

@mproszewska
Copy link
Contributor Author

I added requested changes.

@mproszewska
Copy link
Contributor Author

Everything should be fine now

@jreback jreback merged commit c71bfc3 into pandas-dev:master Jun 4, 2020
@jreback
Copy link
Contributor

jreback commented Jun 4, 2020

thanks @mproszewska

@kuraga
Copy link

kuraga commented Jun 12, 2020

@mproszewska , thanks very much!

But @mproszewska , @jreback , should we add an argument to this line, too, shouldn't we?

if _is_potential_multi_index(columns):

@kuraga kuraga mentioned this pull request Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IO Excel read_excel, to_excel MultiIndex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: read_excel: incorrect multi-index values - 1 (empty or equal values)

4 participants