Skip to content

TST: Add Series.update ExtensionArray tests #34030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 10, 2020
Merged

TST: Add Series.update ExtensionArray tests #34030

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc17ee7
TST: Add Series.update ExtensionArray tests
dsaxton May 6, 2020
a8699cd
Merge remote-tracking branch 'upstream/master' into update-tests
dsaxton May 7, 2020
6ace03a
Merge remote-tracking branch 'upstream/master' into update-tests
dsaxton May 9, 2020
9929eb0
Merge remote-tracking branch 'upstream/master' into update-tests
dsaxton May 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pandas/tests/series/methods/test_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import numpy as np
import pytest

from pandas import DataFrame, Series
from pandas import CategoricalDtype, DataFrame, NaT, Series, Timestamp
import pandas._testing as tm


Expand Down Expand Up @@ -93,6 +93,16 @@ def test_update_from_non_series(self, series, other, expected):
Series([None, False], dtype="boolean"),
Series([True, False], dtype="boolean"),
),
(
Series(["a", None], dtype=CategoricalDtype(categories=["a", "b"])),
Series([None, "b"], dtype=CategoricalDtype(categories=["a", "b"])),
Series(["a", "b"], dtype=CategoricalDtype(categories=["a", "b"])),
),
(
Series([Timestamp(year=2020, month=1, day=1, tz="Europe/London"), NaT]),
Series([NaT, Timestamp(year=2020, month=1, day=1, tz="Europe/London")]),
Series([Timestamp(year=2020, month=1, day=1, tz="Europe/London")] * 2),
),
],
)
def test_update_extension_array_series(self, result, target, expected):
Expand Down