Skip to content

Update test_period_range.py #34175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 15, 2020
Merged

Update test_period_range.py #34175

merged 15 commits into from
May 15, 2020

Conversation

jnecus
Copy link
Contributor

@jnecus jnecus commented May 14, 2020 •
edited by mroeschke
Loading

Attempting to implement test for resolved issue #21793

Update test_period_range.py
a4d6ae4 
Attempting to implement test for resolved issue pandas-dev#21793
@pep8speaks
Copy link

pep8speaks commented May 14, 2020 •
edited
Loading

Hello @jnecus! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-05-15 09:07:12 UTC

@jreback jreback added Index Related to the Index class or subclasses Period Period data type Testing pandas testing functions or related to the test suite labels May 14, 2020
jreback
jreback requested changes May 14, 2020
View reviewed changes
mroeschke
mroeschke reviewed May 14, 2020
View reviewed changes
jnecus and others added 2 commits May 14, 2020 18:08
mroeschke
mroeschke reviewed May 14, 2020
View reviewed changes
mroeschke
mroeschke reviewed May 14, 2020
View reviewed changes
mroeschke
mroeschke reviewed May 14, 2020
View reviewed changes
@jnecus jnecus requested a review from jreback May 15, 2020 09:36
@jreback jreback added this to the 1.1 milestone May 15, 2020
@jreback jreback merged commit 2b67c65 into pandas-dev:master May 15, 2020
@jreback
Copy link
Contributor

jreback commented May 15, 2020

thanks @jnecus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke left review comments

@jreback jreback jreback approved these changes

Assignees

No one assigned

Labels

Index Related to the Index class or subclasses Period Period data type Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

BUG: PeriodIndex comparisons break on listlike

4 participants

@jnecus @pep8speaks @jreback @mroeschke