Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: Deprecate n-dim indexing for Series #35141

Merged
merged 3 commits into from Jul 6, 2020
Merged

DEPR: Deprecate n-dim indexing for Series #35141

merged 3 commits into from Jul 6, 2020

Conversation

TomAugspurger
Copy link
Contributor

Closes #27837

@jorisvandenbossche jorisvandenbossche mentioned this pull request Jul 6, 2020
Closed
@TomAugspurger TomAugspurger added Deprecate Functionality to remove in pandas Indexing Related to indexing on series/frames, not to indexes themselves labels Jul 6, 2020
@TomAugspurger TomAugspurger added this to the 1.1 milestone Jul 6, 2020
TomAugspurger
TomAugspurger commented Jul 6, 2020
View reviewed changes
pandas/core/indexers.py
"version. Convert to a numpy array before indexing instead.",
DeprecationWarning,
stacklevel=3,
FutureWarning,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elevated to a FutureWarning. It was originally a DeprecationWarning for matplotlib.

WillAyd
WillAyd approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TomAugspurger @simonjayhawkins
Update pandas/core/indexers.py
23b1766 
Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
@jreback jreback merged commit 85c02bc into pandas-dev:master Jul 6, 2020
@jreback
Copy link
Contributor

jreback commented Jul 6, 2020

thanks @TomAugspurger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

API: what should a 2D indexing operation into a 1D Index do? (eg idx[:, None])
4 participants
@TomAugspurger @jreback @WillAyd @simonjayhawkins