COMPAT: Ensure rolling indexers return intp

[mroeschke]

• closes CI: MacPython failing test_consistency_with_window #35148
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

Unable to test this locally for the MacPython build, but I am pretty sure this is the main culprit of that failing job.

[jreback]

you can leave entirely in int64 as we do now for all rolling ops

except when you are going to .take() something u have to wrap ensure_intp_dtype around the array

windows should be affected but pass by this change

[mroeschke]

Wouldn't it be better if all the indexers were just platform int to begin with so we don't have to worry about casting?

[jreback]

no int64 are fine

[jreback]

@mroeschke none of this is needed or a good idea. you only need to ensure_platform_int when indexing via .take

[mroeschke]

Going to start over in a new branch

[TomAugspurger]

@mroeschke none of this is needed or a good idea. you only need to ensure_platform_int when indexing via .take

How do we know that it's safe to cast at take time? Ensuring that indicies are the platform int seems like the way to go.

[TomAugspurger]

@mroeschke in case it helps, here's the dockerfile I'm using locally

FROM quay.io/pypa/manylinux1_i686

RUN /opt/python/cp38-cp38/bin/python -m pip install \
  cython \
  numpy \
  python-dateutil \
  pytz \
  pytest \
  hypothesis
COPY pandas /pandas
RUN cd /pandas && /opt/python/cp38-cp38/bin/python setup.py build_ext -i -j 4

Then run it and mount the pandas/ directory to /pandas so you can easily test things.