Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: DataFrame.apply with func altering row in-place #35633

Merged
merged 1 commit into from Aug 11, 2020
Merged

BUG: DataFrame.apply with func altering row in-place #35633

merged 1 commit into from Aug 11, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Aug 8, 2020 •
edited by jreback

closes #35462
closes #35634

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback
Copy link
Contributor

jreback commented Aug 8, 2020

#35634 is another example

@jorisvandenbossche jorisvandenbossche added this to the 1.1.1 milestone Aug 10, 2020
@jreback jreback added Apply Apply, Aggregate, Transform Regression Functionality that used to work in a prior pandas version labels Aug 10, 2020
jreback
jreback requested changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few issues to the header. can you see if your tests covers these as well.

@jbrockmendel
Copy link
Member Author

This does not address #35517 or #35518

@jreback jreback merged commit 993ab08 into pandas-dev:master Aug 11, 2020
@jreback
Copy link
Contributor

jreback commented Aug 11, 2020

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the bug-apply-setitem branch August 11, 2020 03:43
@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.1.x

@meeseeksmachine meeseeksmachine mentioned this pull request Aug 11, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 11, 2020
@jbrockmendel @meeseeksmachine
Backport PR pandas-dev#35633: BUG: DataFrame.apply with func altering…
dfb693e 
… row in-place
simonjayhawkins pushed a commit that referenced this pull request Aug 11, 2020
@meeseeksmachine @jbrockmendel
Backport PR #35633: BUG: DataFrame.apply with func altering row in-pl…
ac40043 
…ace (#35666)

Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
@trenton3983 trenton3983 mentioned this pull request Aug 22, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.1.1
4 participants
@jbrockmendel @jreback @simonjayhawkins @jorisvandenbossche