BUG: Ensure read_spss accepts pathlib Paths (GH33666) #36174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Sep 7, 2020
|
cc @simonjayhawkins possible if can be done before the tag (otherwise nbd) |
jreback
requested changes
Sep 8, 2020
drmrd
force-pushed
the
read-spss-pathlib-path-support
branch
from
3ba49d6
to
de043c2
Compare
drmrd
force-pushed
the
read-spss-pathlib-path-support
branch
from
de043c2
to
9ff4eaf
Compare
|
@jreback I addressed the changes you requested earlier this week, and I believe the PR is ready for another round of review. |
jreback
approved these changes
Sep 13, 2020
|
thanks @drmrd very nice |
|
@meeseeksdev backport 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Sep 13, 2020
simonjayhawkins
pushed a commit
that referenced
this pull request
Sep 13, 2020
…666) (#36347) Co-authored-by: Dan Moore <9156191+drmrd@users.noreply.github.com>
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_spssonly acceptsstr, notPath#33666black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffWrapped the
pathpassed intopandas.io.spss.read_spssin apandas.io.common.stringify_pathcall prior to passing it topyreadstat.read_sav. This fixes #33666. I've also included tests validatingpd.read_spssaccepts strings andpathlib.Paths.