Skip to content

Conversation

dieterv77
Copy link
Contributor

Just wanted to push this fix to see if it looked OK and let the Travis build start.

If it looks ok, i will add something in the release notes and try to write a proper test.

@dieterv77
Copy link
Contributor Author

Added a test and update release notes. squashed into one commit

@dieterv77
Copy link
Contributor Author

@jreback, ok to merge this?

@jreback
Copy link
Contributor

jreback commented May 17, 2013

@dieterv77 looks good to me

dieterv77 added a commit that referenced this pull request May 17, 2013
BUG: (GH3601) Reindex data if reordering time/period index
@dieterv77 dieterv77 merged commit 22d9141 into pandas-dev:master May 17, 2013
@dieterv77 dieterv77 deleted the FixGH3601 branch May 17, 2013 23:58
@ghost
Copy link

ghost commented May 18, 2013

Since the datetimeindex supplies the labels here, why it it mandatory
to plot it in sorted order? at the very least, what about ascending/descending order?

Hardcoding a sort fixes one problem (GH3061), but creates another.
Previously, the user could opt-in (by sorting himself), but now he can't opt-out.
This looks like a regression to me.

Also, @dieterv77 , please mark issues by the miletsone they go into, if you're merging
your own PRs.

@ghost ghost mentioned this pull request May 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants