Skip to content

REF/TYP: consistent return type for Block.replace #37010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2020
Merged

REF/TYP: consistent return type for Block.replace #37010

merged 1 commit into from
Oct 10, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

move some convert logic out of _replace_coerce to avoid an otherwise-duplicated method

@jbrockmendel jbrockmendel added the Typing type annotations, mypy/pyright type checking label Oct 9, 2020
@jreback jreback added this to the 1.2 milestone Oct 10, 2020
@jreback jreback merged commit fcbdb7d into pandas-dev:master Oct 10, 2020
@jreback
Copy link
Contributor

jreback commented Oct 10, 2020

very nice

@jbrockmendel jbrockmendel deleted the ref-replace branch October 10, 2020 18:08
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel
REF/TYP: consistent return type for Block.replace (pandas-dev#37010)
1155326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @jreback