TST: add message matches to pytest.raises in test_duplicate_labels.py GH30999 #37114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arw2019
reviewed
Oct 14, 2020
There was a problem hiding this comment.
Thanks @theMogget for the PR!
Looks good to me.
Regarding flake8 you're good - Continuous Integration checks this and it's all green. For future, however, the relevant section of the contributor docs is here
simonjayhawkins
approved these changes
Oct 14, 2020
|
Thanks both for the quick reviews. :) @arw2019 thanks for the specific link too, it's really helpful! The amount of information is a bit overwhelming sometimes. |
charlesdong1991
added
Code Style
|
thanks @theMogget very nice! |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #30999
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffHello! This is my first PR here. I followed the steps in the contributing guidelines here, but I didn't see anything about
git diff upstream/master -u -- "*.py" | flake8 --diff.When I run the command locally, with
origin/master, it returns no output. I get fatal withupstream/master. Is that expected, and if it isn't, could anyone advise on how to resolve the issue please?Thank you!