Skip to content

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Doesn't appear to affect anything in master, but stumbled on it when implementing the PR do always return views when indexing on columns.

@jreback jreback added the Internals Related to non-user accessible pandas implementation label Oct 31, 2020
@jreback jreback added this to the 1.2 milestone Oct 31, 2020
@jreback
Copy link
Contributor

jreback commented Oct 31, 2020

sure merge on green

@jbrockmendel jbrockmendel merged commit bd2d022 into pandas-dev:master Oct 31, 2020
@jbrockmendel jbrockmendel deleted the bug-slice_canonize branch October 31, 2020 19:32
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
* BUG: slice_canonize incorrectly raising

* GH ref
ukarroum pushed a commit to ukarroum/pandas that referenced this pull request Nov 2, 2020
* BUG: slice_canonize incorrectly raising

* GH ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Internals Related to non-user accessible pandas implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants