Skip to content

TYP/BUG: fix passing incorrect type to interpolate_1d #38306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2020
Merged

TYP/BUG: fix passing incorrect type to interpolate_1d #38306

merged 2 commits into from
Dec 7, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

jreback
jreback requested changes Dec 5, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any additional tests?

@jbrockmendel
Copy link
Member Author

any additional tests?

i dont think so. i checked that we get here with dt64tz but thats about it.

@jreback jreback added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Typing type annotations, mypy/pyright type checking labels Dec 7, 2020
@jreback jreback added this to the 1.2 milestone Dec 7, 2020
@jreback jreback merged commit 9310cb7 into pandas-dev:master Dec 7, 2020
@jreback
Copy link
Contributor

jreback commented Dec 7, 2020

wow typing actually is helping

@jbrockmendel jbrockmendel deleted the typ-interp branch December 7, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback