REF: Index.__new__ #38665
Merged
REF: Index.__new__ #38665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Dec 23, 2020
jreback
added
Constructors
…f-share-constructors
…f-share-constructors
jreback
reviewed
Dec 29, 2020
pandas/core/indexes/base.py
Outdated
| elif inferred in ["floating", "mixed-integer-float", "integer-na"]: | ||
| # TODO: Returns IntegerArray for integer-na case in the future | ||
| return subarr, np.float64 | ||
| data = np.asarray(subarr).astype(np.float64) |
| cls._validate_dtype(dtype) | ||
|
|
||
| if not isinstance(data, (np.ndarray, Index)): | ||
| # Coerce to ndarray if not already ndarray or Index |
There was a problem hiding this comment.
can use _ensure_array on L81
There was a problem hiding this comment.
L81 is inside ensure_array
There was a problem hiding this comment.
oh i c, i guess i meant can you use the super class version
There was a problem hiding this comment.
theres really only one line that gets shared, i dont think its worth it (for now at least)
…f-share-constructors
jreback
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming towards sharing more of this with Series and pd.array