Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 33634: If aggregation function returns NaN the order of the index on the resulting df is not maintained #41017

Merged
merged 16 commits into from May 21, 2021
Merged

Fix 33634: If aggregation function returns NaN the order of the index on the resulting df is not maintained #41017

merged 16 commits into from May 21, 2021

Conversation

DriesSchaumont
Copy link
Member

@DriesSchaumont DriesSchaumont commented Apr 18, 2021 •
edited

@DriesSchaumont DriesSchaumont changed the title Fix 33634: Fix 33634: If aggregation function returns NaN the order of the index on the resulting df is not maintained Apr 18, 2021
@DriesSchaumont DriesSchaumont marked this pull request as ready for review April 18, 2021 19:24
@DriesSchaumont DriesSchaumont added Apply Apply, Aggregate, Transform Bug labels Apr 18, 2021
jreback
jreback requested changes Apr 20, 2021
View reviewed changes
pandas/core/apply.py Outdated Show resolved Hide resolved
doc/source/whatsnew/v1.3.0.rst Outdated Show resolved Hide resolved
jreback
jreback requested changes Apr 23, 2021
View reviewed changes
pandas/core/apply.py Show resolved Hide resolved
jreback
jreback requested changes Apr 30, 2021
View reviewed changes
doc/source/whatsnew/v1.3.0.rst Outdated Show resolved Hide resolved
pandas/core/apply.py Show resolved Hide resolved
rhshadrach
rhshadrach requested changes May 1, 2021
View reviewed changes
pandas/core/apply.py Outdated Show resolved Hide resolved
rhshadrach
rhshadrach requested changes May 14, 2021
View reviewed changes
doc/source/whatsnew/v1.3.0.rst Outdated Show resolved Hide resolved
rhshadrach
rhshadrach approved these changes May 15, 2021
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach
Copy link
Member

cc @jreback

@rhshadrach rhshadrach added this to the 1.3 milestone May 21, 2021
@rhshadrach rhshadrach merged commit 269a3e4 into pandas-dev:master May 21, 2021
@rhshadrach
Copy link
Member

Thanks @DriesSchaumont!

TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
@DriesSchaumont @TLouf
BUG: agg order for list is not maintained (pandas-dev#41017)
71e8f14
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@DriesSchaumont @JulianWgs
BUG: agg order for list is not maintained (pandas-dev#41017)
72c0f4e
@rhshadrach rhshadrach mentioned this pull request Feb 15, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

@jreback jreback Awaiting requested review from jreback

Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform Bug
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

BUG: If aggregation function returns NaN the order of the index on the resulting df is not maintained
3 participants
@DriesSchaumont @rhshadrach @jreback