Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYP deprecate_nonkeyword_arguments #41608

Merged
merged 1 commit into from
May 22, 2021
Merged

TYP deprecate_nonkeyword_arguments #41608

merged 1 commit into from
May 22, 2021

Conversation

MarcoGorelli
Copy link
Member

If we have

import pandas as pd

reveal_type(pd.Series(range(3)).interpolate('linear'))

then on master we get:

$ mypy t.py 
t.py:3: note: Revealed type is 'Any'

while here

$ mypy t.py 
t.py:3: note: Revealed type is 'Union[pandas.core.series.Series, None]'

@MarcoGorelli MarcoGorelli mentioned this pull request May 21, 2021
Merged
4 tasks
@jreback jreback added the Typing type annotations, mypy/pyright type checking label May 21, 2021
@jreback jreback added this to the 1.3 milestone May 21, 2021
@jreback jreback merged commit a68523b into pandas-dev:master May 22, 2021
@jreback
Copy link
Contributor

jreback commented May 22, 2021

thanks @MarcoGorelli

@MarcoGorelli MarcoGorelli deleted the preserve-types-depr-nonkwargs branch May 22, 2021 08:51
TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
@MarcoGorelli @TLouf
type deprecate_nonkeyword_arguments (pandas-dev#41608)
78f1d11
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@MarcoGorelli @JulianWgs
type deprecate_nonkeyword_arguments (pandas-dev#41608)
e8c1bfd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarcoGorelli @jreback