Skip to content

BUG: to_hdf append string column to incompatible column #41897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2021
Merged

BUG: to_hdf append string column to incompatible column #41897

merged 3 commits into from
Jun 17, 2021

Conversation

lrepiton
Copy link
Contributor

@lrepiton lrepiton commented Jun 9, 2021 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@pep8speaks
Copy link

pep8speaks commented Jun 9, 2021 •
edited
Loading

Hello @lrepiton! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-14 08:17:47 UTC

jreback
jreback requested changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm small change and ping on green

@jreback jreback added Bug IO HDF5 read_hdf, HDFStore labels Jun 10, 2021
@lrepiton lrepiton requested a review from jreback June 14, 2021 14:26
@jreback jreback added this to the 1.3 milestone Jun 16, 2021
@jreback jreback merged commit 64c8978 into pandas-dev:master Jun 17, 2021
@jreback
Copy link
Contributor

jreback commented Jun 17, 2021

thanks @lrepiton

@jreback
Copy link
Contributor

jreback commented Jun 17, 2021

@meeseeksdev backport 1.3.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jun 17, 2021
@lrepiton @meeseeksmachine
Backport PR pandas-dev#41897: BUG: to_hdf append string column to inc…
9ff0ca9 
…ompatible column
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 17, 2021
Merged
@lumberbot-app
Copy link

lumberbot-app bot commented Jun 17, 2021

Something went wrong ... Please have a look at my logs.

jreback pushed a commit that referenced this pull request Jun 17, 2021
@meeseeksmachine @lrepiton
Backport PR #41897: BUG: to_hdf append string column to incompatible …
a510291 
…column (#42074)

Co-authored-by: lrepiton <6302028+lrepiton@users.noreply.github.com>
@lrepiton lrepiton deleted the append_invalid_values_axes branch June 17, 2021 16:20
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@lrepiton @JulianWgs
BUG: to_hdf append string column to incompatible column (pandas-dev#4…
4b4bdeb 
…1897)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreback jreback jreback approved these changes

Assignees

No one assigned

Labels

Bug IO HDF5 read_hdf, HDFStore

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

3 participants

@lrepiton @pep8speaks @jreback