REF: de-duplicate CategoricalIndex._get_indexer #42042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Categorical
jreback
approved these changes
Jun 16, 2021
| res = com.asarray_tuplesafe(keyarr) | ||
| if not isinstance(keyarr, ExtensionArray): | ||
| # e.g. we don't want to cast DTA to ndarray[object] | ||
| res = com.asarray_tuplesafe(keyarr) |
There was a problem hiding this comment.
should we just have ExtensionArray pass thru asarray_tuplesafe (would need to change the return signature), not sure if this is used enough to warrant but a thought.
iynehz
pushed a commit
to iynehz/pandas
that referenced
this pull request
Jun 20, 2021
This was referenced Jun 26, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.