Skip to content

Conversation

TAJD
Copy link
Contributor

@TAJD TAJD commented Jun 27, 2021

@mzeitlin11
Copy link
Member

Thanks for the pr @TAJD! Think the test failure is because the test assumes int64, but on 32-bit builds or windows, the default integer size will be int32. So I'd suggest just not trying to match as completely or could use numpy's platform int

@mzeitlin11 mzeitlin11 added Constructors Series/DataFrame/Index/pd.array Constructors Dtype Conversions Unexpected or buggy dtype conversions Testing pandas testing functions or related to the test suite labels Jun 27, 2021
@TAJD
Copy link
Contributor Author

TAJD commented Jun 27, 2021

Thanks @mzeitlin11 - hopefully by allowing 32 or 64 in the regex on the error message tests the required functionality.

@jreback jreback added this to the 1.4 milestone Jul 1, 2021
@jreback
Copy link
Contributor

jreback commented Jul 1, 2021

this is fine, though the message actually is slightly misleading, you are actually trying to cast to a nullable type, but the underlying casting is bubbled up here.

so merging this, but would be neat to look into having a slightly more informative message here.

@jreback jreback merged commit ce83026 into pandas-dev:master Jul 1, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Constructors Series/DataFrame/Index/pd.array Constructors Dtype Conversions Unexpected or buggy dtype conversions Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bounds checks for IntegerArray

3 participants